[PATCH] Stackable auras

[fatherbushido]

This ticket is related to : ​#3522. Actually, auras are not stackable. But there is some side effects with capture. For example : If one have two macedonians theater (one and one captured), auras don't stack. But if one have one macedonian theater and one spartan theater (captured), auras stack.

[fatherbushido]

As discussed on irc with elexis and sanderd17, we can use other robust keys/identifiers for auras such that auras never stack. We also add an optional flag in auras template which always allow stacking.

[fatherbushido]

rebased on 17810

[fatherbushido]

This sets wonder as stackable.

[fatherbushido]

According to our discussion :​/irclogs, there is a problematic case. If player with civ A have for example a temple with an aura wich modify the same value by adding 5 and a player with civ B have a temple with an aura wich modify the same value by adding 10, what is expected ?

The patch have a good reaction and affects units with only one of this aura (the first which applies). But this situation may not occurs since it doesn't make sense. One solution that mimo's give is the following :

• it would be nice to ensure that all auras have the same value for all civs
• differences would be introduced by civ specific technologies (now that they can apply to auras) possibly autoresearched

So as tech will apply to the player civ, we don't care if it's temple A or B which applies its aura, since the value will be the same.