Changes between Version 2 and Version 3 of Ticket #4220, comment 12


Ignore:
Timestamp:
Feb 4, 2017, 4:22:30 PM (7 years ago)
Author:
fatherbushido

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #4220, comment 12

    v2 v3  
    22
    33- I would use `!` instead of `no`
    4 - Take care that the `GuiInterface` split of the `CanCapture` and `CanAttack` stuff had some reason (so with that merging L234 of Attack is wrong).
     4- Take care that the `GuiInterface` split of the `CanCapture` and `CanAttack` stuff had some reason (so with that merging L234 of Attack is wrong). -> EDIT: It seems I read too fast
    55- The fix of the remaining bug in #3484 is more or less linked to this one. I don't want to do stuff wich will conflict with what you have in mind. So I guess that you should provide the UnitAI modification with that patch too (you can use type or still do the stuff by passing the allowCapture bool).
    66- about namming, perhaps types is enough clear