Changes between Version 1 and Version 2 of Ticket #4276, comment 1


Ignore:
Timestamp:
Oct 9, 2016, 6:11:15 PM (8 years ago)
Author:
fatherbushido

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #4276, comment 1

    v1 v2  
    1 When we don't hit the target at the expected location, if we hit a nearby unit. It looks like we invert the test collision check. I don't know if we need to remove the break or not. It is shown in #4241.
     1First patch: 1910_splash_strengths.diff​
     2
     3We didn't parse the splash strengths to the damage component (we needed the Ranged and the Ranged.Splash stats in `MissileHit`). The above patch fixes that. We can also return a more complex object in `GetAttackStrengths` and use this one.
     4
     5Second patch: 1910_nearbyUnits.diff
     6
     7When we don't hit the target at the expected location, if we hit a nearby unit. It looks like we invert the test collision check. It is shown in #4241.
    28The patch above fixes that.