#4698 closed defect (fixed)
OOS on rejoin when using Vectors - Use prototype serialization code
Reported by: | fatherbushido | Owned by: | wraitii |
---|---|---|---|
Priority: | Must Have | Milestone: | Alpha 24 |
Component: | Core engine | Keywords: | |
Cc: | leper, Krinkle | Patch: | Phab:D2746 |
Description (last modified by )
The commit in r19147 and r19154 shows issues with serialization of prototype (for js vector objects).
Here is a sum up of forum discussions (mainly a leper's investigation).
We have unused prototype serialization code (#407), that should most likely be used (see #1089 for an use for AI deserialization). Though it might be worth considering not making this opt-in (or at least failing loudly if we try to serialize something with an unknown prototype).
The attached diffs are wip, possibly broken and ugly (from leper). It shows the breakage though it seems that the test is incomplete.
Attachments (2)
Change History (14)
by , 7 years ago
Attachment: | serialization_vector_js_object.diff added |
---|
by , 7 years ago
Attachment: | serialization_vector_js_object_fix.diff added |
---|
comment:1 by , 7 years ago
Description: | modified (diff) |
---|
comment:2 by , 6 years ago
comment:3 by , 6 years ago
comment:4 by , 6 years ago
Milestone: | Backlog → Alpha 24 |
---|---|
Priority: | Should Have → Must Have |
Summary: | Use prototype serialization code → OOS on rejoin when using Vectors - Use prototype serialization code |
This is a vietnam mantrap for OOS errors.
The first release of Alpha 23 stores a Vector2D in Danubius' riverDirection
and thus triggers an OOS on rejoin.
comment:6 by , 5 years ago
Cc: | added |
---|
comment:7 by , 5 years ago
Owner: | set to |
---|
comment:8 by , 5 years ago
Status: | new → assigned |
---|
comment:9 by , 4 years ago
Patch: | → https://code.wildfiregames.com/D1991 |
---|
comment:10 by , 4 years ago
Owner: | changed from | to
---|---|
Patch: | https://code.wildfiregames.com/D1991 → Phab:D2746 |
Status: | assigned → new |
https://trac.wildfiregames.com/ticket/5162#comment:25