Changes between Initial Version and Version 2 of Ticket #4839


Ignore:
Timestamp:
Dec 1, 2017, 11:00:36 PM (6 years ago)
Author:
elexis
Comment:

Perhaps the StartingCamera feature could be used in a campaign where we do have a civic center + a hero somewhere else and it should focus the hero instead.

The feature is still broken in in the map loader, in the simulation and in the gameview afaics. Most maps likely have a starting camera value that should be removed in case the code will sometime prefer the starting camera of players specified in the map.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #4839

    • Property Priority Must Have → Nice to Have
    • Property Milestone Alpha 23 → Backlog

  • Ticket #4839 – Description

    initial v2  
    1 TLDR: For alpha 23, we must add code to center the camera location in observermode.
     1The camera position should always be centered in observermode.
     2r20370 removed some code that pretends to center the camera. But that only works for observers, it should be on a per-player basis as long as the other maps 'support' that too.
     3My impression that `ParseCamera` in `MapReader.cpp` is unusably broken.
     4The `Player` component also has camera positioning code which appears unused.
    25
    3 When playing games, opening skirmish/scenario maps in atlas or generating random maps in atlas, the camera focuses on an entity of the player.
    4 
    5 If the map doesn't come with any player entities (about impossible and if possible, likely wants to use a cinematic path), or more likely:
    6 
    7 if the game is started in observer/replaymode, then the random map determines the initial camera location
    8 
    9 r20370 removed some code that pretends to center the camera.
    10 
    11 But the impression that `ParseCamera` in `MapReader.cpp` is unusably broken is very strong.
    12 
    13 So it seems there is no use case to save a camera position in any of the map types.
    14 
    15 So the code could be removed instead of fixed. The camera location could then be comptued in the same place for both players and observers.
    16 
    17 The `Player` component also has camera positioning code which appears unused.
     6The GameView code always focuses on the first CC if there exists one. Thus overwriting the StartingCamera from the (skirmish/scenario/random) map if one exists, reverting its only use case.