Opened 6 years ago
Closed 3 years ago
#5255 closed defect (fixed)
FreeBSD porting patches
Reported by: | Guido Falsi | Owned by: | Stan |
---|---|---|---|
Priority: | Should Have | Milestone: | Alpha 24 |
Component: | Build & Packages | Keywords: | |
Cc: | Patch: | Phab:D1592, Phab:D1593, Phab:D1594, Phab:D2399 |
Description (last modified by )
Hi,
While updating the FreeBSD port to Alpha 23 I encountered a few problems, especially on FreeBSD 12 (the development version) due to the newer version of clang.
I'm planning to send code reviews for the required patches, grouping them logically. I need some time to port them to the present subversion tree.
I'll track those reviews here for reference, if that's ok.
Change History (11)
comment:1 by , 6 years ago
comment:2 by , 6 years ago
Created review for patches required to work with newer clang (6.0.0 and higher):
comment:3 by , 6 years ago
Description: | modified (diff) |
---|
comment:4 by , 6 years ago
Created review to conditionalize use of MAP_NORESERVE, which is not known by FreeBSD mmap:
comment:5 by , 6 years ago
I'm also seeing this problem:
> ActorEditor Cannot open "../../../binaries/system/libAtlasUI.so"
Which is caused by this command during compilation:
c++ -o "../../../binaries/system/ActorEditor" obj/ActorEditor_Release/ActorEditor.o -fstack-protector -L../../../binaries/system -L/usr/local/lib -Wl,--no-undefined -Wl,--as-needed -Wl,-z,relro -Wl,-rpath,/usr/local/lib/0ad ../../../binaries/system/libAtlasObject.a ../../../binaries/system/libAtlasUI.so
I need to check, I'm almost sure that the final
../../../binaries/system/libAtlasUI.so
should be
-lAtlasUI.so
so that the rpath option would apply its magic.
I am trying to understand how to coerce the build system in doing things this way and test this theory. I'm open to suggestions.
follow-up: 7 comment:6 by , 6 years ago
Cc: | added |
---|---|
Component: | Non-game systems → Build & Packages |
Thanks for your work :) In case you didn't know we will make another release soonish because of GDPR and some annoying bugs. I'll see if I can get Itms to review those patches :) in the meantime you can set him as reviewer on Phabricator.
comment:7 by , 6 years ago
Replying to stanislas69:
Thanks for your work :) In case you didn't know we will make another release soonish because of GDPR and some annoying bugs. I'll see if I can get Itms to review those patches :) in the meantime you can set him as reviewer on Phabricator.
I did set Itms as reviewer, thanks!
BTW any pointer on where to look to fix the ActorEditor problem would be appreciated, I'm digging into the premake lua files but can't really find what needs to be modified.
comment:8 by , 5 years ago
Cc: | removed |
---|---|
Patch: | → Phab:D1592, Phab:D1593, Phab:D1594 |
comment:9 by , 5 years ago
Patch: | Phab:D1592, Phab:D1593, Phab:D1594 → Phab:D1592, Phab:D1593, Phab:D1594, Phab:D2399 |
---|
Created review for updates psutil patch:
https://code.wildfiregames.com/D1592