Changes between Initial Version and Version 1 of Ticket #748, comment 33


Ignore:
Timestamp:
Apr 16, 2012, 10:20:11 PM (12 years ago)
Author:
historic_bruno

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #748, comment 33

    initial v1  
    22
    33I think your patch will leak the `NSBitmapImageRep` and `NSImage` objects because they get [https://developer.apple.com/library/mac/documentation/Cocoa/Reference/Foundation/Classes/NSObject_Class/Reference/Reference.html#//apple_ref/occ/clm/NSObject/alloc allocated] but not [https://developer.apple.com/library/mac/documentation/Cocoa/Reference/Foundation/Protocols/NSObject_Protocol/Reference/NSObject.html#//apple_ref/occ/intfm/NSObject/release released]. I'm not 100% comfortable with !Cocoa/Obj-C but I think you should release them as soon as the reference is no longer needed (a quick search confirms this usage, e.g. [http://fossies.org/dox/gtk+-2.24.10/gdkcursor-quartz_8c_source.html here]).
     4
     5There is a space after the ":" on line 49 of `osx_sys_cursor.mm`, but not any of the others.