Changes between Version 2 and Version 3 of Ticket #824, comment 12


Ignore:
Timestamp:
Mar 1, 2012, 11:42:52 PM (12 years ago)
Author:
vts

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #824, comment 12

    v2 v3  
    1515
    1616I'd like to have this patch reviewed, because I'm not sure I got everything quite right. In particular, some things I'd like to note/get reviewed:
    17     - The !QuadBatchKey and !QuadBatchData structures are used by !OverlayRenderer to group quads by texture for efficient rendering using a boost::unordered_map. I'd like to make sure I got the copy semantics and everything right. The key uses shared_ptrs, so I think it should be ok, but I'd prefer to be sure.
     17    - The !QuadBatchKey and !QuadBatchData structures are used by !OverlayRenderer to group quads by texture for efficient rendering using a boost::unordered_map. I'd like to make sure I got the copy semantics, hashing and equality and everything right. The key uses shared_ptrs, so I think it should be ok, but I'd prefer to be sure.
    1818    - I've added a slightly modified version of the territory border overlay shader; I'm not familiar with writing shaders, and it seems to work fine, but nonethelesss I'd like to have it inspected if possible.
    1919    - I chose to add pointers to both a dynamic overlay and a static overlay to the CCmpSelectable component, and have only one of them be in use at any given time. Compared to alternatives like centralized registration in some sort of !SelectionManager component, this has the advantage that they can be managed by their own component (CCmpSelectable can cleanly receive messages and invalidate them when needed). On the other hand, this does not lend itself well to further extensions of the possible overlay types (can't just keep adding pointers). For now though, I think this will do.