Changes between Version 12 and Version 13 of SubmittingPatches


Ignore:
Timestamp:
Feb 28, 2014, 2:51:30 AM (10 years ago)
Author:
Josh
Comment:

Recommend asking for patch review on IRC if it has not been reviewed after awhile.

Legend:

Unmodified
Added
Removed
Modified

  • SubmittingPatches

    v12 v13  
    1111 * One of the core developers should then review it and maybe suggest some changes.
    1212 * When it's considered okay, they should commit it to SVN.
    13  * If you don't hear anything within a reasonable time period (maybe a week or two), feel free to post a reminder on the [http://www.wildfiregames.com/forum/index.php?showforum=312 forum]. Some patches take longer to review due to low priority, high complexity, or special knowledge required to review it. We appreciate your patience and all contributions.
     13 * If you don't hear anything within a reasonable time period (maybe a week or two), feel free to post a reminder on the [http://www.wildfiregames.com/forum/index.php?showforum=312 forum] or ping the developers on [http://webchat.quakenet.org/?channels=0ad-dev IRC]. Some patches take longer to review due to low priority, high complexity, or special knowledge required to review it. We appreciate your patience and all contributions.
    1414 * For more "controversial" changes and gameplay features, it's a good idea to create a topic on the forum anyway, to get as much feedback as possible from the community.
    1515 * Also, it's a good idea if you take some time to test patches yourself as well. Even just downloading/applying the patch and compiling it and testing if it does as it's supposed to is highly valuable. (Maybe the developer only has access to Linux, and you're on Windows or Mac, so even just testing to see if it compiles can be a good thing.) You don't have to know all the code to be able to test patches.