Opened 12 years ago

Closed 12 years ago

Last modified 8 years ago

#1062 closed defect (fixed)

[PATCH] It is odd that pointer to 'char' type is compared with the '\0' value. Probably meant: *ext == '\0'.

Reported by: Echelon9 Owned by:
Priority: Should Have Milestone: Alpha 9
Component: Core engine Keywords:
Cc: Patch:

Description

A potential error: a pointer to the char type is compared to value '\0'. It is highly probable that the pointer dereferencing operation is missing.

Proposed patch attached.

Attachments (1)

ogl-char-pointer-fix.patch (399 bytes ) - added by Echelon9 12 years ago.
Proposed fix for ogl.cpp pointer to char comparison

Download all attachments as: .zip

Change History (4)

by Echelon9, 12 years ago

Attachment: ogl-char-pointer-fix.patch added

Proposed fix for ogl.cpp pointer to char comparison

comment:1 by Erik Johansson, 12 years ago

Milestone: Alpha 8Alpha 9

comment:2 by philip, 12 years ago

Resolution: fixed
Status: newclosed

(In [10821]) Fix #1062 (incorrect check for empty string), based on patch by Echelon9

comment:3 by sanderd17, 8 years ago

Keywords: review removed
Note: See TracTickets for help on using tickets.