[PATCH] The return value of function 'remove_if' is required to be utilized.

[Echelon9]

Calls of some functions are senseless if their results are not used.

Example: The std::remove function does not remove elements from the container. It only shifts the elements and brings the iterator back to the beginning of the trash. Suppose we have the vector<int> container that contains elements 1,2,3,1,2,3,1,2,3. If we execute the code "remove( v.begin(), v.end(), 2 )", the container will contain elements 1,3,1,3,?,?,?, where ? is some trash. The function will bring the iterator back to the first senseless element, so if we want to remove these trash elements, we must write the code this way: "v.erase(remove(v.begin(), v.end(), 2), v.end())".

Proposed code is attached.

[Echelon9]

Proposed fix for adt_cache std::remove_if approach

[Jan Wassenberg]

(In [10818]) minor fixes waio: ensure error is disk_full on failure cache_adt: scaffolding code wrongly used std::remove_if instead of list::remove. thanks to Echelon9 for catching this! fixes #1063