[PATCH] [ATLAS] Display template name for selected units

[vts]

In Atlas, there does not currently appear to be any indication a selected unit's template name. This is useful for people who can't tell on sight what kind of unit they have selected.

I figure a sensible place to display it would be in the bottom panel of the Object tab, somewhere next to the Player dropdown perhaps, but suggestions are welcome.

[Michael Roussel]

I will try to do something like that (Selected templates)

[Michael Roussel]

This is the screenshot in the attachment "Atlas - Scenario Editor - (untitled)_002.png" It's only a visual. Tell me if you have any suggestions.

[leper]

Any progress?

[Adi]

This patch works on displaying the selected entities (eg. units, animals, buildings etc) but not with "non-interactive" actors (eg. trees). Should I add a new panel for those actors OR display the template names in the same panel as the entities?

The only issue I found right now with this patch is that the horizontal scroll bar doesn't show on long template names. I'm not experienced with this wxWidgets stuff so any hint is welcomed :)

One issue I found with selecting the "non-interactive actors": on my instance I can't select them right now, only the entities, but this might be a OS issue (Ubuntu, Alt key is assigned to "move" window...).

[Josh]

Not an in-depth review, but there's some commented code that should be removed if it's not used anymore in source/tools/atlas/AtlasUI/ScenarioEditor/Tools/Common/ObjectSettings.cpp.

[Adi]

I unbinded my Alt key in the OS so I managed to test this better. Selecting non-interactive actors works fine also, they are shown in the same panel as the entities. (maybe we could use different colors?)

The only issue remains with the horizontal scrollbars on long template names. I will work on this bug and I'll re-factor the code a bit (as sanderd17 suggested on irc) then I'll send a new patch.

[Adi]

In the new patch I re-factored the code a bit and, as sanderd17 suggested, I added tooltips for long template names as horizontal scrollbars are not always best for ux. I think this task should be completed now.

[Josh]

From a purely stylistic point of view it looks good. Functionally, I'm not familiar with how atlas works so I can't accurately comment on that. However, nothing stands out as looking particularly wrong.

[Adi]

Thanks for the review, Josh. I added a quick update to my previous patch, I removed RefreshObjectSettings, a method which was declared but not used/implemented

[Adi]

Added some small changes based on leper's review.

[Stan]

Hey Adrian fatol did you think of adding itas an excel window with columns like position variation rotation name script name. For each item selected ? Do you think you could do that ?

[Adi]

Hey stanislas69, I don't understand what you mean by "adding itas an excel window with columns", could you be more specific?

[Stan]

Sure something like this http://www.wildfiregames.com/forum/uploads//monthly_03_2014/post-12287-0-04192400-1394979341.png

[Adi]

It should be possible. I don't know where I could get all that info from, but I'll look into it.

[Stan]

I think it´s written in the xml and with th cmp stuff in ccmpmanager.cpp

[leper]

Why do you remove the

if (selection.empty())
    return;

? The line after that accesses selection[0], so if selection.empty() == true you have undefined behaviour.

[Itms]

Hello Adrian, I don't know if you plan to continue working on 0 A.D.

I'm marking this patch as reviewed since leper pointed out a fault in it. However we'd be glad if you decided to finish it! :)

Otherwise, there is no problem, just drop by and tell us so we can know someone else can take care of this.

Thanks for your work so far!

[trompetin17]

I added my fix, could you review please :).

Here is the video about how is going to work ​http://youtu.be/tGeQKPcwF8s

[trompetin17]

I added the counter template names

[Itms]

In 16255:

Add a list of selected entities, grouped by template.

Patch by trompetin17, fixes #1392

[Itms]

Thanks for the patch!