Opened 12 years ago
Last modified 4 years ago
#1518 closed task
Submit premake modifications to upstream — at Version 6
| Reported by: | leper | Owned by: | |
|---|---|---|---|
| Priority: | Nice to Have | Milestone: | |
| Component: | Build & Packages | Keywords: | |
| Cc: | Yves, fabio | Patch: |
Description (last modified by )
We bundle a modified version of premake 4.3 to create our workspaces (VS projects, makefiles, ...).
Some of our modifications are bug fixes (relative paths, precompiled headers), enhancements (cxxtest support, nasm support) or extensions to upstream features (os_getversion support for POSIX sytems (os_getversion is a backport from premake-4.4-beta4)).
It would be nice to
- submit these modifications to upstream by adding a pull request there. See the premake contribution guidelines for information on how to submit patches.
- add diff/patch files and a readme describing the use of the modification to the premake dir (analogous to how we handle nvtt modifications). (could be useful for the first task)
The attached file is a diff against the imported premake version (see link above) before r11970.
Change History (7)
by , 12 years ago
| Attachment: | 0ad_premake.diff added |
|---|
comment:1 by , 12 years ago
| Cc: | added |
|---|
comment:2 by , 12 years ago
I added a pull request with our additions to getversion() upstream https://bitbucket.org/premake/premake-dev/pull-request/25/add-unix-support-to-osgetversion.
comment:3 by , 11 years ago
| Cc: | added |
|---|
comment:4 by , 11 years ago
The pull request hasn't been merged, but a slightly modified version of it has been committed to premake-dev and premake-stable (which will become 4.4).
We still need to adjust our local version to be the same as the code upstream, but that shouldn't be hard to do.
comment:5 by , 11 years ago
Ideally there should be also a configure option for using system premake, similar to nvtt/mozjs/enet.
comment:6 by , 11 years ago
| Description: | modified (diff) |
|---|
This is sort of the reason for this ticket (and to keep us from having to maintain a fork), but we depend on some of the modifications and I don't know (for all of them) wether they are still used/needed or if they should just be dropped. (I added Yves to cc some time ago as he did most of those changes afaik)
Also premake-dev (which will become 5.0) changes a lot of the api so we will probably have to do some work once that is released (or hits beta).
And just that I mentioned it here #1516 should probably be fixed properly and submitted too..
CCing Yves as he did most of the changes to premake.