Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#1558 closed defect (fixed)

[PATCH] Drop-down lists are not reinitialized properly.

Reported by: Deiz Owned by: Deiz
Priority: Should Have Milestone: Alpha 11
Component: Core engine Keywords: patch
Cc: Patch:


As the HandleMessage functions all return void, there's no way to easily determine whether a dropdown's child list has been modified after handling a message.

For a demonstration of the issue at present, go to set up a match, change the map selection filter to "Old Maps" - notice the dropdown is still large despite there being zero maps. Now, change back to 'Default' and notice it's only showing one map.

More or less, the buggy behaviour results in the dropdown rectangle's size lagging until it has been assigned to twice.

Having the list track when it's updated its items allows the dropdown to detect the modification and reinitialize the list size properly.

Attachments (1)

dropdown-list.patch (2.5 KB ) - added by Deiz 12 years ago.

Download all attachments as: .zip

Change History (3)

by Deiz, 12 years ago

Attachment: dropdown-list.patch added

comment:1 by Deiz, 12 years ago

Resolution: fixed
Status: newclosed

In 12244:

Properly re-initialize drop-down lists when the list items changes. Fixes #1558.

comment:2 by Deiz, 12 years ago

Keywords: review removed
Note: See TracTickets for help on using tickets.