Opened 12 years ago

Closed 12 years ago

#1594 closed defect (fixed)

Handle sound system errors more gracefully

Reported by: historic_bruno Owned by: stwf
Priority: Should Have Milestone: Alpha 12
Component: Core engine Keywords:
Cc: stwf Patch:

Description

I've added some logging to the new sound system so at least we can see if the OpenAL device init fails, but it will eventually lead to a null pointer dereference and crash since there's minimal error checking in place. In general the errors need to be more descriptive and the error conditions handled more gracefully.

Change History (6)

comment:1 by historic_bruno, 12 years ago

Milestone: BacklogAlpha 12

comment:2 by stwf, 12 years ago

Owner: set to stwf
Status: newassigned

comment:3 by stwf, 12 years ago

this is much improved by the path in fix 1604

http://trac.wildfiregames.com/ticket/1604

comment:4 by ben, 12 years ago

In 12566:

Sound system patch by stwf:
Fixes sound system to work with archives (use VFS files instead of POSIX), fixes #1604.
Improves error handling and logging, refs #1594.
Allows sound to be disabled with -nosound/-quickstart runtime options or --without-audio build option, fixes #1609, #1614.
Experimentally increases default buffer size to help prevent sound stoppages.

comment:5 by stwf, 12 years ago

This should be fixed now

comment:6 by Kieran P, 12 years ago

Resolution: fixed
Status: assignedclosed

Marking as fixed. Please reopen if the problem reoccurs.

Note: See TracTickets for help on using tickets.