[PATCH] Show unmet requirements in technology icon tooltips

[zoot]

Show unmet requirements in technology icon tooltips.

See ​this thread for discussion.

[historic_bruno]

Some comments from looking at the patch:

• At first I wasn't sold on the need for a custom tooltip formatting syntax, but looking at all the possibilities, it may be the best option.
• We should probably go ahead and plan on handling multiple requirements per tech, which may need a recursive design of the tooltip string building function.
• The required count appears red, as if it's an unmet requirement. It will remain red even when the count is satisfied, which is an inconsistency in the UI. The logic would only grow messier to solve that with conditional colors or visibility.
• I think the logic in GetRequirementsVars() should be combined with getFormattedRequirementsTooltip()

I guess the question is: do we want to keep this as simple as possible and only handle the case of a single class requirement per tech (which could be easily special-cased), or do we want to make it super flexible and handle all possibilities? The former would certainly be a simpler, neater solution. I don't know if we plan any techs that require a more complicated solution.

[Kieran P]

Moved to the next release as further work is required.

[zoot]

Sorry, I seem to have missed the last comments here.

Replying to historic_bruno:

• We should probably go ahead and plan on handling multiple requirements per tech, which may need a recursive design of the tooltip string building function.

Would it not be better to do that when multiple requirements are implemented? Then we will know how the format will look.

• The required count appears red, as if it's an unmet requirement. It will remain red even when the count is satisfied, which is an inconsistency in the UI. The logic would only grow messier to solve that with conditional colors or visibility.

This is not strictly true. When the count is satisfied, the check on ​unit_commands.js:673 will fail, and the string won't be shown in the tooltip.

• I think the logic in GetRequirementsVars() should be combined with getFormattedRequirementsTooltip()

GetRequirementsVars() is really just a glorified getter, modelled on the structure of CheckTechnologyRequirements(). The idea being that all the logic for parsing technology requirements should be contained in the component to which it is native.

I can copy it over if you insist, but then the logic has to be maintained in two different files. Alternatively, I could try to find a way to combine GetRequirementsVars() and CheckTechnologyRequirements() (or at least have one call the other)?

[scythetwirler]

It'd be nice to indicate which structures actually count as village/town phase structures on their individual structure tooltips for newer players.

[elexis]

In r19120 by fatherbushido:

Merge different logics of technology requirements and fix the related bugs. Create a global script which derive the technology requirements objects in a form usable for structure tree, gui, simulation and AI. Reviewed by mimo (for AI) and fatherbushido. Fixes #3993, #1646, #4263, #4217. Refs #4108.

In r19121 by fatherbushido:

Add a simulation test to the previous commit of s0600204's patch. Refs #4263.