Opened 11 years ago

Closed 11 years ago

#1713 closed defect (fixed)

[PATCH] Selection sound plays on unit death

Reported by: historic_bruno Owned by: zoot
Priority: Nice to Have Milestone: Alpha 12
Component: UI & Simulation Keywords: patch
Cc: stwf, zoot Patch:

Description

Original report by zoot here.

Select some of your own units, target them to attack another entity. When the target entity dies, you will hear its selection sound. If your units are not selected, you won't hear the selection sound. Not sure if this is related to the new sound manager or some changes made in selection handling.

Change History (7)

comment:1 by historic_bruno, 11 years ago

Cc: zoot added

comment:2 by zoot, 11 years ago

Keywords: review added
Milestone: Backlog → Alpha 12
Owner: set to zoot
Status: new → assigned
Summary: Selection sound plays on unit death → [PATCH] Selection sound plays on unit death

Fix for this: ​https://github.com/zootzoot/0ad/compare/1713.diff

See explanation here: http://www.wildfiregames.com/forum/index.php?showtopic=16715&#entry257415

comment:3 by Kieran P, 11 years ago

Milestone: Alpha 12 → Alpha 13

comment:4 by Kieran P, 11 years ago

Priority: Should Have → Nice to Have

comment:5 by historic_bruno, 11 years ago

Keywords: patch added

comment:6 by historic_bruno, 11 years ago

Keywords: review removed
Milestone: Alpha 13 → Alpha 12

Thanks for the patch. I made a slight change so that it checks a true quiet parameter instead of checking for a false playsound (it's too easy to confuse the difference between testing x and x !== false in JS). The patch seems to work and it's small so I'm committing for A12. Also cleaned up a few comments in the script.

comment:7 by ben, 11 years ago

Resolution: → fixed
Status: assigned → closed

In 12973:

Fixes unit promotions triggering a selection sound, based on patch by zoot. Fixes #1713

Note: See TracTickets for help on using tickets.