#1778 closed enhancement (fixed)
[PATCH] Remember last name and IP at "Join Game" dialog
| Reported by: | Aurélio A. Heckert | Owned by: | leper |
|---|---|---|---|
| Priority: | Should Have | Milestone: | Alpha 13 |
| Component: | Core engine | Keywords: | patch |
| Cc: | Patch: |
Description
In the future a hole new full featured dialog will be nice, but, by now, remembering the last used "player name" and "server IP" will be a great help.
Attachments (2)
Change History (10)
by , 11 years ago
| Attachment: | 0ad-adding-GetDefaultMPServer.diff added |
|---|
comment:1 by , 11 years ago
| Milestone: | Backlog → Alpha 13 |
|---|---|
| Summary: | Remember last name and IP at "Join Game" dialog → [PATCH] Remember last name and IP at "Join Game" dialog |
comment:2 by , 11 years ago
| Keywords: | patch review added |
|---|
comment:4 by , 11 years ago
| Keywords: | review removed |
|---|
I applied your change with a little modification (There is no default to 127.0.0.1 in the code as there is for "anonymous", so I removed the .empty() check and added it as the default to system.conf).
Regarding your question on IRC (as I'm not sure that you are reading the logs):
Check SetSplashScreenEnabled in source/gui/scripting/ScriptFunctions.cpp
by , 11 years ago
| Attachment: | 0ad-adding-RecordLastMPServerAndPlayer.diff added |
|---|
The last 50% to close the ticket.
comment:5 by , 11 years ago
| Keywords: | review added |
|---|
comment:6 by , 11 years ago
| Owner: | set to |
|---|
As already noted on IRC I found a bug in the CreateValue function and I want to fix this in one go, so I'm assigning this to myself. Thanks for the patch!
Note:
See TracTickets
for help on using tickets.
50% of the feature request, adding the ability to remember the server.