Opened 7 years ago

Last modified 13 months ago

#1785 new enhancement

[PATCH] Attack type icons in tooltips

Reported by: Cerridan Owned by:
Priority: Should Have Milestone: Backlog
Component: UI – In-game Keywords: patch, beta
Cc: Patch:

Description (last modified by Imarok)

This patch puts attack type icons in tooltips.

It also changes Range: to be the ranged attack icon.

Attachments (2)

AttackIcons.zip (4.7 KB) - added by Cerridan 7 years ago.
Icons and patch file.
AttackIcons.patch (5.1 KB) - added by Cerridan 7 years ago.
Patch file.

Download all attachments as: .zip

Change History (13)

Changed 7 years ago by Cerridan

Attachment: AttackIcons.zip added

Icons and patch file.

Changed 7 years ago by Cerridan

Attachment: AttackIcons.patch added

Patch file.

comment:1 Changed 7 years ago by Cerridan

Keywords: patch added; ui removed

comment:2 Changed 7 years ago by Jonathan Waller

Description: modified (diff)

Thanks for the patch. The code looks good to me. This is basically a design decision. I updated the description to note that this also changes the word Range: to the ranged attack icon.

Last edited 7 years ago by Jonathan Waller (previous) (diff)

comment:3 Changed 7 years ago by alpha123

This looks nice. I have two minor complaints: attack icons are after the numbers, whereas resource icons are before the numbers, and it took me a bit to figure out what the icon for "range" meant (as in Range: 16).

The first one you may have already addressed; IIRC, I mentioned it on the forums. If you'd upload the new patch here that would be good.

Last edited 7 years ago by alpha123 (previous) (diff)

comment:4 in reply to:  2 Changed 7 years ago by historic_bruno

Keywords: review, patchreview patch

Replying to quantumstate:

This is basically a design decision

Something for a design committee?

comment:5 Changed 7 years ago by Kieran P

All icons come before the number. Consider this:

You don't say "15: Range", but you do say "Range: 15".

So why should you say "15: [range icon]" instead of "[range icon]: 15" ?

So bottom line, make the icons go before the number it represents, and also make sure that padding is consistent with other icons.

comment:6 Changed 7 years ago by Kieran P

Milestone: Alpha 13Alpha 14

comment:7 Changed 7 years ago by historic_bruno

Keywords: review removed
Milestone: Alpha 14Backlog

Thanks for the patch, but I don't really like the trend of adding so many icons to what are already fairly ugly tooltips (and I don't think I'm alone in that assessment), so I'm going to bump this to the backlog. We'll redesign the tooltips, and if we still need these icons in the UI, we'll have the patch to use.

comment:8 Changed 6 years ago by historic_bruno

Owner: Cerridan deleted

comment:9 Changed 3 years ago by scythetwirler

Keywords: beta added

comment:10 Changed 2 years ago by Imarok

Description: modified (diff)

I think we really need attack type icons. Stan do you want to do some?

comment:11 Changed 13 months ago by Imarok

Component: UI & SimulationIn-game UI

Move tickets to In-game UI as UI & Simulation got some sub components.

Note: See TracTickets for help on using tickets.