r13313 unnecessarily disable water effects on Win 7

[fabio]

While on IRC Philip said an HD2500 ( ​http://irclogs.wildfiregames.com/2013-03-17-QuakeNet-%230ad-dev.log ) was very slow with water effects enabled on Ubuntu 12.04 and disabled them with all OSs. I tested an HD3000 on Windows 7 and noticed very little performance difference with any of the water effects (while looking at a river). I'd suggest enabling it again on Windows 7. It would be nice to test on an updated Ubuntu, since HD2500 was still experimental on 12.04, but cannot do currently.

[historic_bruno]

Does it work if you override those settings in your local.cfg?

[fabio]

What do you mean with "does it work"? What should I try?

[historic_bruno]

Set these variables to enable all the fancy water effects:

 waternormals = true
 waterrealdepth = true
 waterfoam = true
 watercoastalwaves = true
 waterrefraction = true
 waterreflection = true
 watershadows = true

Which might override the changes introduced in r13313.

It's true that's not as nice as having these capabilities detected, but it's not currently feasible (pending #145/#1810), and most of the advanced graphics is disabled by default on all systems anyway.

[fabio]

Confirmed also adding the variables to the config file. Almost no renderer time change (using the F11 profiler).

[historic_bruno]

The water renderer has also changed since this ticket, does anyone have insight into how it performs now on Intel HD GPUs across different OSes?

[fabio]

I tried it now on a HD3000 SandyBridge on both Linux and Windows, some water features slow down rendering a little bit indeed now. I am for leaving the settings as is now. One can still enable or disable through options menu some settings if he prefer a little better graphic with a bit lower fps. Closing.