AI can spawn units before the needed technologies are researched

[sanderd17]

Even with the new AI interface, Aegis bot can still spawn some of the units without researching the needed technology.

For example, it can spawn champion units from barracks before it's even in city phase, so it couldn't have researched the "champion units" technology.

I don't know if there are other places where a technology limits unit creation. There's one I know, with Athenian triremes, but as the AI can't do naval warfare yet, that won't matter. But it'd be worth handling this on an a more abstract level, so all future similar cases will be handled correctly.

[leper]

That's because of the || cmpPlayer.IsAI() checks in Commands.js​ with a TODO next to it. As we still have qbot and that doesn't support technologies the checks are still there.

The proper way of handling this would be to remove the IsAI() checks, but that would break qbot and would require us to either fix it or drop it.

[sanderd17]

Well, there are 2 AI interfaces, can't the old one get a property like cmpPlayer.IsAIv2(). That way, old bots like demo bot or qbot would still work.

And meanwhile give a property IsAIv3() to Aegis bot, because there could (and probably will) be newer iterations anyway.

[sanderd17]

Now the AI is broken, but it should certainly be fixed for A14.

Since the barracks are in village phase, it would mean the AI can already produce champion units when in village phase.

[historic_bruno]

Replying to leper:

The proper way of handling this would be to remove the IsAI() checks, but that would break qbot and would require us to either fix it or drop it.

I think it's to the point where we want to consider that. Maintaining these different APIs is a nightmare, and with wraitii's rewrite coming soon...

[wraitii]

In 14639:

Improve some building placement. May improve dropsite usage slightly.
Should fix #1964

[sanderd17]

In 14640:

Removing the AI check for producing un-allowed units. Should be fixed in the AI side with r14639. Refs #1964.

[sanderd17]

In 14641:

An addition to r14640, also refs #1964