[BUG] CInput::UpdateText() crash in Debug build

[Jorma Rebane]

In VC++11.0 or higher, CInput::UpdateText() will crash in debug build with error: Iterators incompatible.

This is due to std::list<SRow>::erase invalidating the iterators and no code to update the active iterators.

The actual fix is very simple.

Previously the code relied on undefined behavior to run.

[historic_bruno]

Could we do this:

current_line = m_CharacterPositions.erase(destroy_row_from, destroy_row_to);

instead of setting current_line before the erase? That should always be the correct, valid iterator? (it also fixes the assertion failure)

[Jorma Rebane]

Less hacky fix

[Jorma Rebane]

Replying to historic_bruno:

Could we do this:

current_line = m_CharacterPositions.erase(destroy_row_from, destroy_row_to);

instead of setting current_line before the erase? That should always be the correct, valid iterator? (it also fixes the assertion failure)

Changed and tested. Works exactly the same. New patch file added with the one-liner.

[leper]

In 13539:

Fix crash in VC++11 debug builds. Fixes #2028. Patch by RedFox.

[leper]

Thanks.