Opened 11 years ago
Closed 10 years ago
#2029 closed enhancement (wontfix)
[PATCH] ShaderDefines freaky cache fix
| Reported by: | Jorma Rebane | Owned by: | Jorma Rebane |
|---|---|---|---|
| Priority: | Must Have | Milestone: | |
| Component: | Core engine | Keywords: | patch performance |
| Cc: | Patch: |
Description
Currently the exceptionally strange cache method implemented in ShaderDefines.cpp is actually worse for performance.
With some small tweaks and removing a lot of unnecessary code, managed to reduce the number of CShaderParam instances to a bare minimum.
Also replaced weird cache system in ShaderManager. Much easier to combine hashes in ShaderManager than implementing custom hashers.
Attachments (1)
Change History (3)
by , 11 years ago
| Attachment: | ShaderDefines_freakycache.patch added |
|---|
comment:1 by , 11 years ago
| Milestone: | Alpha 14 → Alpha 15 |
|---|
comment:2 by , 10 years ago
| Keywords: | review removed |
|---|---|
| Milestone: | Alpha 15 |
| Resolution: | → wontfix |
| Status: | new → closed |
Closing these tickets as no further active development is expected. See Philip's megapatch-split git branch for an attempt at splitting megapatch into it's separate parts: http://git.wildfiregames.com/gitweb/?p=0ad.git;a=shortlog;h=refs/heads/projects/philip/megapatch-split
Note:
See TracTickets
for help on using tickets.
Initial fix of the strange cache method in ShaderDefines.cpp