#2163 closed enhancement (fixed)
[PATCH] Content sensitive group icon
Reported by: | Josef Kufner | Owned by: | elexis |
---|---|---|---|
Priority: | Nice to Have | Milestone: | Alpha 21 |
Component: | UI & Simulation | Keywords: | patch |
Cc: | Patch: |
Description
Group buttons at the left edge of the screen have universal icon which only shows number of the group. It woud be more useful to use icon of majority unit in the group. Like a little preview. The number should be visible in the corner of the button.
If there is same amount of units (five elephants and five villagers), the more expensive one should be used first (the elephant icon).
Change History (7)
comment:1 by , 11 years ago
Summary: | Group icon → Content sensitive group icon |
---|
comment:2 by , 11 years ago
comment:3 by , 11 years ago
Adding less specific icons is more work than using icon of major unit in group. And it will make buttons less specific...
comment:4 by , 8 years ago
Keywords: | patch rfc added |
---|---|
Milestone: | Backlog → Alpha 21 |
Summary: | Content sensitive group icon → [PATCH] Content sensitive group icon |
comment:6 by , 8 years ago
Component: | Core engine → UI & Simulation |
---|---|
Keywords: | rfc removed |
Type: | defect → enhancement |
Thanks for the patch as usual :)
I made those 2 functions local, since they were not used anywhere else and added a comment. Also made it a template
argument of the cost function, so it would be hopefully less confusing (since the group argument you had in there before represents only a subset of the group)
Agreed. This would be a nice feature. And the icons don't have to be super specific. There can be a horse/cavalry icon, an infantry icon, a "support" icon, a generic ship icon, etc.