Remove multiply_color effect because it's deprecated

[Michael]

Remove multiply_color effect because it's deprecated from

• binaries/data/mods/public/gui/gui.rnc (don't forget to generate the .rng afterwards)
• GUI_-_Sprites
• somewhere else ?

[Stan]

Can't find the file, the only missing reference seems to be the wiki. Close it ?

[Itms]

It's in the RelaxNG grammar now. Fixed the description.

[historic_bruno]

Yeah, the grammars need to be fixed since there have been a number of changes since they were generated. I'm sure this isn't the only one.

[s0600204]

I've taken the liberty of removing mention of the former "multiply_color" effect from the wiki page. (And added mention of the "color:" and "grayscale:" sprite shortcuts.) Hope no-one minds.

[Stan]

In 20832:

Remove the last occurence of multiply_color in the repo.
Fixes #2422

[elexis]

I'm sure this isn't the only one

Stan did/can you check if this is was the only property?

Because if we know that there are more deprecated settings in the validation file, those should be removed and we should have an open, possibly simple ticket to remind ourselves of that.

[Stan]

I checked for mutliply color in the repo. But maybe some other are deprecated if you find some create a ticket ;)

[elexis]

It was good to commit the removal the known unused deprecated property.

But as historic_bruno mentioned, there is a reason to believe that there are more deprecated properties. So auditing the file (and answering the "somewhere else?" question in the ticket summary) is a remaining task IMO. (The task is mostly a string-search I suppose.)

[Stan]

I thought that ticket was only about multiply_color not every deprecated property we have, if any. Maybe it should be changed to reflect that ?

[elexis]

Either that or the one closing a ticket reads through the comments for relevant remaining aspects of a ticket before marking it as fixed.