Opened 10 years ago
Closed 10 years ago
#2530 closed defect (fixed)
Barter tooltip not translated
Reported by: | mimo | Owned by: | |
---|---|---|---|
Priority: | Nice to Have | Milestone: | Alpha 17 |
Component: | Internationalization & Localization | Keywords: | |
Cc: | Patch: |
Description
The barter tooltip http://trac.wildfiregames.com/browser/ps/trunk/binaries/data/mods/public/gui/session/unit_commands.js#L1009 is not translated
Attachments (1)
Change History (6)
by , 10 years ago
Attachment: | barter.diff added |
---|
comment:1 by , 10 years ago
This won't work, as the string will never get extracted.
You need to make sure that both action and resource are translatable (or don't have to be translated), then use the sprintf style to combine them to one string.
So the first work is to find out where the strings come from, and either (if it's part of the GUI), translate them there, or (if it's part of the simulation), mark them for translation. For the latter, you still need to translate them in the GUI itself.
comment:3 by , 10 years ago
It will try to find something like "sell stone" in the po files, which it won't find (it's silly to have all combinations in it). Instead, the po file should contain all resource names (which it already does), and the sell/buy actions. Then it should search for a string like "%(action)s %(resourceType)s", which also needs to be translated, as some languages might reverse the order. And then fill in those variables with translated names.
But take a look at the wiki first. It's a bit hard to explain it all here.
comment:4 by , 10 years ago
Keywords: | simple added |
---|---|
Milestone: | Alpha 17 → Alpha 18 |
comment:5 by , 10 years ago
Keywords: | simple removed |
---|---|
Milestone: | Alpha 18 → Alpha 17 |
Resolution: | → fixed |
Status: | new → closed |
I forgot about this ticket. It's already fixed.
Fix for the string.