[PATCH] Having more than one observer crashes

[Josh]

Having more than one observer in a multiplayer game can frequently crash due to incorrect initial assignment of any observer in CNetServerWorker::AddPlayer (source:ps/trunk/source/network/NetServer.cpp#L609​).

Possible solutions are initially assigning all joining players the ID -1 in the network code and allowing gamesetup to correct as needed. Or the network code could try to determine if a player should be an observer or not.

[Stan]

maybe an enum with player types

enum {
TYPE_PLAYER;
TYPE_OBSERVER;
TYPE_AI;
TYPE_RECORDER; // This one would be nice if we want to have replays of all the games. (Could be usefull to solves fights, and to make promotionnal stuff with the best games.
}

[Josh]

I've attached a patch following my first idea for a solution (assign the player ID in gamesetup) which seems to work in limited local testing.

[Josh]

Fix crash by assigning new player IDs in gamesetup.

[Josh]

Leper reviewed the patch and I've responded to his suggestions. I'll commit this tomorrow if there are no objections.

[JoshuaJB]

In 15171:

Fix multiple observers on multiplayer games to work more reliably. Fixes #2529

[Imarok]

In 19215:

Reset ready state when non-observers join in gamesetup

Reviewed by: elexis

Differential Revision: ​https://code.wildfiregames.com/D50
Fixes #4452. Refs #2529. Refs rP15171, rP17443, rP18299.

[elexis]

r15171 had two bugs: (1) It assumed that there all N clients are assigned to the first N slots, fixed in #3607 (2) It didn't reset the ready state (only coincidentally when replacing an AI, not when replacing an unassigned slot), fixed by r19215