Developer Overlay should not have a global, persistent config setting

[scythetwirler]

If the Developer Overlay is enabled in the settings, it is automatically opened in unrated games which is only an annoyance. Therefore, the setting should be removed and the developer overlay should only be openable via keyboard shortcut.

[Josh]

This is intended.

[leper]

This is non-obvious and already hit some lobby users. We shouldn't automatically open it in MP games.

[Josh]

Replying to leper:

This is non-obvious and already hit some lobby users. We shouldn't automatically open it in MP games.

How else are they going to open the developer overlay?

[leper]

Alt+D

[Josh]

Replying to leper:

Alt+D

All that does is enable the config setting.

[Josh]

Maybe we could check that it's not rated and that cheats are enabled before displaying it in-game?

[Erik Johansson]

I don't really see why there's a setting to always open the developer overlay in the first place? That just seems to be causing the confusion you mention, but without much added benefit as far as I understand (it's not as if it's difficult to press Alt+D I mean, and I doubt most people will need it every time they launch the game), but maybe I'm just missing something here :P

[leper]

Replying to Josh:

All that does is enable the config setting.

Why does it even do that? Pressing any other hotkey doesn't make make persistent changes either.

I also agree with Erik that the setting isn't very useful, I'm probably going to revert part of the commit(s) (r15007 and r15010) that introduced that.

[Josh]

I can change it to not use a config setting. As we used to have one in the in-game settings menu, I figured I should copy it to the new global options menu.

[JoshuaJB]

In 15205:

Change developer overlay to only be openable through Alt+D shortcut. Fixes #2569