#2777 closed defect (fixed)
[PATCH] Missing Background Images
| Reported by: | Stan | Owned by: | leper |
|---|---|---|---|
| Priority: | Should Have | Milestone: | Alpha 17 |
| Component: | UI & Simulation | Keywords: | patch |
| Cc: | Patch: |
Description
When starting the game on SVN version you sometimes gets errors of missing textures that's because the game is trying to load background that doesn't exist.
http://trac.wildfiregames.com/browser/ps/trunk/binaries/data/mods/public/gui/pregame/mainmenu.js#L4
We have an old background in the Art source before release it should be decided to either use it or not.
Attachments (3)
Change History (12)
follow-up: 2 comment:1 by , 10 years ago
comment:2 by , 10 years ago
I was only able to cause the error when
const background = "persians1";
Is the imagery for persians1 being developed elsewhere?
Will we want many different opening screens - one for each civilization for example -
and if that is the case then maybe a more segmented layout would be desirable.
follow-up: 4 comment:3 by , 10 years ago
No nobody is drawing something in that aim for the moment, that means, there is little chance something like that will happen.
by , 10 years ago
| Attachment: | mainmenu.js_remove-extra-variable_.patch added |
|---|
Slightly more encompassing removal of the multiple backgrounds.
comment:4 by , 10 years ago
Replying to stanislas69:
No nobody is drawing something in that aim for the moment, that means, there is little chance something like that will happen.
Perhaps mainmenu.js_remove-extra-variable_.patch would be more appropriate. That way there is no dangling code to become invalid.
follow-up: 6 comment:5 by , 10 years ago
Having multiple backgrounds is still planned (or at least something that is worths supporting. The persians1 images were removed some time ago (they were ugly).
Make that function have a switch and make hellenes the default case.
comment:6 by , 10 years ago
Replying to leper:
Make that function have a switch and make hellenes the default case.
Works for me. Patch attached.
comment:7 by , 10 years ago
| Keywords: | patch added |
|---|---|
| Summary: | Missing Background Images → [PATCH] Missing Background Images |
comment:9 by , 10 years ago
| Component: | Core engine → UI & Simulation |
|---|---|
| Keywords: | review removed |
Thanks for the patch. I also removed the used objects from the gui xml file.
It would be nice if you would create patches from the root directory, that makes applying them a lot faster.
After making some research with the bug reporter I realised it only happened because he forced the game to load them. Still those lines should be removed.