Opened 10 years ago

Closed 10 years ago

#2778 closed defect (fixed)

GUI Using a lot of turn time ~150ms/per frame

Reported by: Stan Owned by: Itms
Priority: Release Blocker Milestone: Alpha 17
Component: Core engine Keywords:
Cc: Patch:

Description

Steps to reproduce :

  • Open Atlas : Place 200 hoplites
  • Select Them
  • Open the profiler (F11)

Expected Output :

This was not present in A16 and shouldn't be there in A17

Possible Causes :

Some modifications to gui files must have triggered it

OS/Version

r15702  Windows 8.1.1 64bits on an I5-3210 HD8750M 8GB Ram.

Change History (4)

comment:1 by Niek, 10 years ago

I encountered something similar (as I already reported to historic_bruno.). Whenever I start a game in svn and select a unit/building the GUI tick takes ~10msec more, spiking from 3 msec to 13 causing a huge framedrop.

This wasn't the case in Alpha 16 where the GUI tick takes <1msec without selecting something and raising to roughly 1~2msec.

comment:2 by Stan, 10 years ago

I can confirm that happens in the game too. Selecting ten units make it go from 3msc/frame to 30msec/frame.

comment:3 by Itms, 10 years ago

Owner: set to Itms

Well, once again git bisect basically said "Man, WTH did you do when you worked on fogging?". r15612 is the faulty commit, I think I know precisely where the problem comes from.

comment:4 by Itms, 10 years ago

Resolution: → fixed
Status: new → closed

In 15703:

Revert an unoptimized GUI update from r15612. Instead, notify directly the GUI in case of miraged entities, and treat them the same way we treat renamed entities.

Fixes #2778

Note: See TracTickets for help on using tickets.