Opened 10 years ago

Closed 10 years ago

#2830 closed defect (fixed)

[PATCH] Tooltip should have their Counters line removed

Reported by: scythetwirler Owned by: Timothy Hamlett
Priority: Should Have Milestone: Alpha 18
Component: UI & Simulation Keywords:
Cc: tjh.hts@… Patch:

Description (last modified by Timothy Hamlett)

Hard counters have been removed but there are still some tooltips with their Counters line remaining.

UPDATE: I missed one in the original patch.

Attachments (3)

removecountertooltips.patch (14.5 KB ) - added by Timothy Hamlett 10 years ago.
This should remove everything.
removecountertooltips2.patch (13.0 KB ) - added by Timothy Hamlett 10 years ago.
Updated the patch.
sele_cavalry_archer_b.xml.patch (1.4 KB ) - added by Timothy Hamlett 10 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 by Timothy Hamlett, 10 years ago

Cc: tjh.hts@… added
Owner: set to Timothy Hamlett

comment:2 by Timothy Hamlett, 10 years ago

Keywords: review patch added
Summary: Tooltip should have their Counters line removed[PATCH] Tooltip should have their Counters line removed

I think I fixed it

by Timothy Hamlett, 10 years ago

Attachment: removecountertooltips.patch added

This should remove everything.

comment:3 by Itms, 10 years ago

About the current patch:

  • Leave the "Can run amok" for the two first templates (you can add a "TBD" if you want.
  • Fix some periods you removed (probably by accident).

Thanks for working on this!

by Timothy Hamlett, 10 years ago

Updated the patch.

comment:4 by Itms, 10 years ago

Resolution: fixed
Status: newclosed

In 15867:

Remove some "Counters/Countered by" tooltips as the hard counters system has been disabled.

Patch by thamlett, fixes #2830

comment:5 by Itms, 10 years ago

Keywords: simple review patch removed

Thanks for the patch, don't hesitate to reopen the ticket if someone comes across some remaining tooltips.

comment:6 by Timothy Hamlett, 10 years ago

Description: modified (diff)
Resolution: fixed
Status: closedreopened

by Timothy Hamlett, 10 years ago

comment:7 by Itms, 10 years ago

Resolution: fixed
Status: reopenedclosed

In 15879:

Remove another leftover "Counter" string, see also r15867.
Patch by thamlett, fixes #2830

Note: See TracTickets for help on using tickets.