Opened 10 years ago

Closed 10 years ago

Last modified 8 years ago

#2831 closed defect (fixed)

[PATCH] Removes Leftover Techs

Reported by: Nikos Owned by: scythetwirler
Priority: Should Have Milestone: Alpha 17
Component: UI & Simulation Keywords: Technology, patch
Cc: badreligionnikoss@… Patch:

Description

Athenian Gymnasion and Spartan Syssition had a tech pair that had to be removed, as it was removed from all other factions with alpha 17 changes, probably an oversight.

Attachments (1)

structures.patch (1.2 KB ) - added by Nikos 10 years ago.

Download all attachments as: .zip

Change History (12)

by Nikos, 10 years ago

Attachment: structures.patch added

comment:1 by Nikos, 10 years ago

Summary: Removes Leftover Techs[PATCH] Removes Leftover Techs

comment:2 by Nikos, 10 years ago

Cc: badreligionnikoss@… added
Component: Build & PackagesUI & Simulation

comment:3 by Niek, 10 years ago

Keywords: patch review added

comment:4 by s0600204, 10 years ago

There are a number of other technologies that aren't researchable from any structures anymore since the rebalance, but still exist in the technologies folder. (I can provide a list.)

Would it be a good idea to include them for removal?

comment:5 by Niek, 10 years ago

Probably they could be preserved for making civs unique in the future.

comment:6 by Nikos, 10 years ago

Yeah several of them might be reintroduced or edited to something similar, I'd say let them be.

Last edited 10 years ago by Nikos (previous) (diff)

comment:7 by njm, 10 years ago

line 42 in athen_gymnasion.xml in structures.patch

      </ProductionQueue>

is indented too much. I think it should have only 2 instead of 6 spaces.

Last edited 10 years ago by njm (previous) (diff)

comment:8 by s0600204, 10 years ago

niektb/prodigal_son: Fair enough, I see your point. Although they will still exist in the repository history, making them just a svn copy away.

For reference purposes I've put the list of currently unused techs on pastebin: http://pastebin.com/J4Y76dhR

How about removing the old pair_* files that point to techs that are still in use but are no longer paired? (See the end of the pastebin link.)

njm: I agree.

comment:9 by Nikos, 10 years ago

On the code part, it could be a mistake on my part (you mean it has some unnecessary spaces right?). Those were the first files I ever edited for 0 AD.

If it's so easy to retrieve files, then it wouldn't be a bad idea to remove them, but maybe ask scythe first, he might have plans to use some of them soon. Same with the pairs I guess.

Last edited 10 years ago by Nikos (previous) (diff)

comment:10 by scythetwirler, 10 years ago

Owner: set to scythetwirler
Resolution: fixed
Status: newclosed

In 15834:

Fixes #2831. Patch by prodigalson.

comment:11 by sanderd17, 8 years ago

Keywords: review removed
Note: See TracTickets for help on using tickets.