Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#2900 closed defect (fixed)

[PATCH] Implement Rotary Mill Aura

Reported by: Niek Owned by: Itms
Priority: Should Have Milestone: Alpha 18
Component: UI & Simulation Keywords:
Cc: Patch:

Description

Attached patch implements the planned rotary mill aura by bonusing nearby farming with 25%. Also updates the tooltip and removes the technology.

Attachments (2)

rotarymillaura.patch (3.3 KB ) - added by Niek 6 years ago.
patch that implement aura and removes obsolete tech
rotarymillaura.2.patch (3.3 KB ) - added by stanislas69 6 years ago.
Update : Patch by niektb, Added the two dots.

Download all attachments as: .zip

Change History (7)

by Niek, 6 years ago

Attachment: rotarymillaura.patch added

patch that implement aura and removes obsolete tech

comment:1 by historic_bruno, 6 years ago

Does this work? I constructed a test map in Atlas but even with a much higher gather bonus, wasn't able to see any difference between farming near or far away from a rotary mill.

Also, do the effects stack with multiple rotary mills?

in reply to:  1 comment:2 by Niek, 6 years ago

Replying to historic_bruno:

Does this work? I constructed a test map in Atlas but even with a much higher gather bonus, wasn't able to see any difference between farming near or far away from a rotary mill.

Also, do the effects stack with multiple rotary mills?

Not anymore, there was a problem with escaping dots. see #2945 and r16010. To make it work <ResourceGatherer.Rates.food.grain> should be changed into <ResourceGatherer.Rates.food..grain> (with double dots)

I believe effects don't stack (as the auras have the same name)

Last edited 6 years ago by Niek (previous) (diff)

comment:3 by stanislas69, 6 years ago

I'm not so sure... #2920

Last edited 6 years ago by historic_bruno (previous) (diff)

by stanislas69, 6 years ago

Attachment: rotarymillaura.2.patch added

Update : Patch by niektb, Added the two dots.

comment:4 by Itms, 6 years ago

Owner: set to Itms
Resolution: fixed
Status: newclosed

In 16174:

Implement the Rotary Mill aura for Celtic factions. Patch by niektb, fixes #2900.

Also remove the placeholder technology and the rotary mill generic Celtic template, and rename the rotary mill portrait. Refs #2619.

comment:5 by Itms, 6 years ago

Keywords: patch review removed

Thanks for the patch! :D

Note: See TracTickets for help on using tickets.