AI - Petra: Naval errors

[brian]

Occurred on github version. Rev: 0c13394b318b0e0ff1e67483d857e643eb2be1e4

---

WARNING: PlayerID 4 | Petra: dock constructed without base index 0

ERROR: JavaScript error: simulation/ai/petra/transportPlan.js line 557 ReferenceError: attackPan is not defined m.TransportPlan.prototype.resetUnit@simulation/ai/petra/transportPlan.js:557 m.TransportPlan.prototype.onBoarding/<@simulation/ai/petra/transportPlan.js:295 m.EntityCollection.prototype.forEach@simulation/ai/common-api/entitycollection.js:142 m.TransportPlan.prototype.onBoarding@simulation/ai/petra/transportPlan.js:233 m.TransportPlan.prototype.update@simulation/ai/petra/transportPlan.js:221 m.NavalManager.prototype.update@simulation/ai/petra/navalManager.js:658 m.HQ.prototype.update@simulation/ai/petra/headquarters.js:2081 m.PetraBot.prototype.OnUpdate@simulation/ai/petra/_petrabot.js:121 m.BaseAI.prototype.HandleMessage@simulation/ai/common-api/baseAI.js:83

ERROR: JavaScript error: simulation/ai/petra/transportPlan.js line 283 TypeError: oldPos is undefined m.TransportPlan.prototype.onBoarding/<@simulation/ai/petra/transportPlan.js:283 m.EntityCollection.prototype.forEach@simulation/ai/common-api/entitycollection.js:142 m.TransportPlan.prototype.onBoarding@simulation/ai/petra/transportPlan.js:233 m.TransportPlan.prototype.update@simulation/ai/petra/transportPlan.js:221 m.NavalManager.prototype.update@simulation/ai/petra/navalManager.js:658 m.HQ.prototype.update@simulation/ai/petra/headquarters.js:2081 m.PetraBot.prototype.OnUpdate@simulation/ai/petra/_petrabot.js:121 m.BaseAI.prototype.HandleMessage@simulation/ai/common-api/baseAI.js:83

WARNING: JavaScript warning: simulation/ai/petra/transportPlan.js line 262 reference to undefined property self.boardingPos[shipId]

ERROR: JavaScript error: simulation/ai/common-api/utils.js line 32 TypeError: a is undefined m.SquareVectorDistance@simulation/ai/common-api/utils.js:32 m.TransportPlan.prototype.onBoarding/<@simulation/ai/petra/transportPlan.js:262 m.EntityCollection.prototype.forEach@simulation/ai/common-api/entitycollection.js:142 m.TransportPlan.prototype.onBoarding@simulation/ai/petra/transportPlan.js:233 m.TransportPlan.prototype.update@simulation/ai/petra/transportPlan.js:221 m.NavalManager.prototype.update@simulation/ai/petra/navalManager.js:658 m.HQ.prototype.update@simulation/ai/petra/headquarters.js:2081 m.PetraBot.prototype.OnUpdate@simulation/ai/petra/_petrabot.js:121 m.BaseAI.prototype.HandleMessage@simulation/ai/common-api/baseAI.js:83

ERROR: Script message handler OnGarrisonedUnitsChanged failed

ERROR: JavaScript error: simulation/components/Trader.js line 56 TypeError: gain is null Trader.prototype.CalculateGain@simulation/components/Trader.js:56 Trader.prototype.OnGarrisonedUnitsChanged@simulation/components/Trader.js:277 GarrisonHolder.prototype.EjectOrKill@simulation/components/GarrisonHolder.js:681 GarrisonHolder.prototype.OnGlobalOwnershipChanged@simulation/components/GarrisonHolder.js:599

ERROR: Script message handler OnGlobalOwnershipChanged failed

[mimo]

In 16136:

fix a typo, addresses #2998

[mimo]

Using the commands.txt of the zip file, I can't reproduce the problems. But it looks like it is not the right commands.txt: in the interestinglog.html, the first warning occurs for player4 while the commands.txt has only 2 players.

[mimo]

In 16143:

Petra fix js warning when building cart super_dock, addresses #2998

[brian]

I also thought it was odd that the interesting log had four players in it considering I thought it was a two player match. I've attached all the sim logs on that map from that day, but they mostly seem too small considering that the game lasted awhile.

[mimo]

Two sources of warnings were fixed in r16136 and r16143. I can't reproduce the other errors (not the right commands.txt). As the code has changed since the bug report, I close it as fixed, fill free to reopen if it happens again.