Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#3058 closed defect (fixed)

[PATCH] Random Naval Map "Islands" broken

Reported by: elexis Owned by: Stan
Priority: Should Have Milestone: Alpha 18
Component: Core engine Keywords: patch
Cc: Patch:

Description

The naval random map "Islands" (the one with desert ground texture) crashes, no matter which settings I use. 

ERROR: JavaScript error: maps/random/islands.js line 220
TypeError: g_MapSettings.PlayerData[(id - 1)] is null
  @maps/random/islands.js:220:3
ERROR: CMapGeneratorWorker::Run: Failed to load RMS 'maps/random/islands.js'

Attachments (2)

3058.1.diff​ (737 bytes ) - added by Stan 9 years ago.
That patch fixes it for me. I believe the bug had to do with modification on gaia id.
3058.2.diff​ (694 bytes ) - added by Stan 9 years ago.
Better Fix

Download all attachments as: .zip

Change History (8)

comment:1 by Stan, 9 years ago

I can confirm that.

by Stan, 9 years ago

Attachment: 3058.1.diff​ added

That patch fixes it for me. I believe the bug had to do with modification on gaia id.

comment:2 by Stan, 9 years ago

Keywords: review patch added; random map script removed
Owner: set to Stan
Summary: Random Naval Map "Islands" broken → [PATCH] Random Naval Map "Islands" broken

comment:3 by elexis, 9 years ago

That patch works, no matter if 1 or 6 players. Every island inhabited by a player has a dock near the center of the map (instead of a crash).

by Stan, 9 years ago

Attachment: 3058.2.diff​ added

Better Fix

comment:4 by mimo, 9 years ago

Resolution: → fixed
Status: new → closed

In 16347:

fix #3058, patch from Stan

comment:5 by mimo, 9 years ago

Keywords: review removed

Thanks for the patch

comment:6 by elexis, 9 years ago

I checked all random map scripts in r16352, all working.

Last edited 9 years ago by elexis (previous) (diff)
Note: See TracTickets for help on using tickets.