Opened 9 years ago

Last modified 6 years ago

#3085 new defect

Alignment error in German AI summary screen

Reported by: Raymond Owned by:
Priority: Should Have Milestone: Backlog
Component: Internationalization & Localization Keywords:
Cc: Patch:

Description (last modified by Itms)

Alignment error in German AI summary screen

In "Verschiedenes" > Getötet / Tote Quote The "G" is not fully readable

and

Gebäude > "Verwaltungssitz"

see screenshots

Version: A18 build 16404

Attachments (6)

Summary_Screen_A18_German_bug1.PNG (182.6 KB ) - added by Raymond 9 years ago.
Summary_Screen_A18_German_bug2.PNG (236.8 KB ) - added by Raymond 9 years ago.
layout.js.patch (2.1 KB ) - added by Jaison 9 years ago.
SVN Patch
layout.js (10.4 KB ) - added by Jaison 9 years ago.
working layout.js file of patch.
translate to Dorfzentren.PNG (119.5 KB ) - added by Jaison 9 years ago.
de.public-gui-other.po (64.7 KB ) - added by Jaison 9 years ago.
data\mods\public\l10n

Download all attachments as: .zip

Change History (22)

by Raymond, 9 years ago

by Raymond, 9 years ago

comment:1 by Jaison, 9 years ago

Owner: set to Jaison
Status: newassigned

comment:2 by Jaison, 9 years ago

I have solved this problem. Review by an svn developer to takeover still required. When problems please contact me, I'll take care of you immediately report it.

When ready update for takeover / fixed, please state (fixed or close) by dev.

Last edited 9 years ago by Jaison (previous) (diff)

by Jaison, 9 years ago

Attachment: layout.js.patch added

SVN Patch

by Jaison, 9 years ago

Attachment: layout.js added

working layout.js file of patch.

comment:4 by Jaison, 9 years ago

Status: assignedreopened
Summary: Alignment error in German AI summary screen[PATCH]Alignment error in German AI summary screen

comment:5 by Jaison, 9 years ago

Resolution: fixed
Status: reopenedclosed

comment:6 by Stan, 9 years ago

Resolution: fixed
Status: closedreopened

comment:7 by Stan, 9 years ago

Keywords: review patch added

Please read http://trac.wildfiregames.com/wiki/SubmittingPatches before posting fixes. Also, let the team close tickets :)

comment:8 by Jaison, 9 years ago

Hi Stanislas, yes I know, I had not even made it to close, it would re-open when I saw it but it was shut down by itself again.

I had placed only on the status (fixed), after which he was somehow closed by itself.

comment:9 by leper, 9 years ago

Keywords: review removed

Which of the attached files is the actual patch? There is only one diff and multiple files after it.

"Quote" is a bad translation anyways, which should be fixed first before adjusting the space for it. Also note the long strings translation (must be generated using a script) to properly test for available space. "Verwaltungssitze" can be split up without any issue.

comment:10 by Jaison, 9 years ago

layout.2.js can be deleted.

layout.js & layout.js.patch​ is correct.

Is at the moment a suggestion, think it could be improved in the translation.

Old: Verwaltungssitze / New: Verwaltungs sitze ?

comment:11 by Stan, 9 years ago

BTW : Setting ticket as fixed closes it. To ask for review, modify the tickets keywords :)

comment:12 by Jaison, 9 years ago

I have the translation of (administrative seat) & (quota) transifex revised.

Please the patch is no longer needed, take over the translation so that it is resolved.

Tested with: resolution 1024/768, works by me.

Delete please: layout.js.patch​ / layout.2.js​ and layout.js.​

comment:13 by leper, 9 years ago

"Verwaltungs- sitze" (where the space causes a line break, though "Verwaltungs-\nsitze" would probably be the better choice). I'm quite certain that I used that for that exact string some time ago, probably someone changed it for no real reason...

Regarding your changes to the translations: The ratio one was a bit better and a bit worse after your change, fixed it up a bit, haven't checked the spacing yet. The CC one you changed was not the one in question, so I reverted that.

comment:14 by Jaison, 9 years ago

Many translations do not, as German are many things not understood or are not well translated, as they were translated by translators.

My proposal was so right tackle at least understandable did you yes revised again.

(Verwaltungssitze ) should be more (Dorfzentren) are called, sounds better in any case.

by Jaison, 9 years ago

by Jaison, 9 years ago

Attachment: de.public-gui-other.po added

data\mods\public\l10n

in reply to:  14 comment:15 by leper, 9 years ago

Replying to Jaison:

Many translations do not, as German are many things not understood or are not well translated, as they were translated by translators.

I know, there is a reason not all strings are marked as translated, and if translators just change some stuff without looking at other strings (global (translation) context and commonly used words) they aren't doing something positive IMO.

My proposal was so right tackle at least understandable did you yes revised again.

(Verwaltungssitze ) should be more (Dorfzentren) are called, sounds better in any case.

No. We've had this discussion time and again, and Dorfzentrum is a worse discussion. This is not AoE and just copying translations from some other game without having a look at the context does not make sense.

comment:16 by Stan, 9 years ago

Keywords: patch removed
Owner: Jaison removed
Status: reopenednew
Summary: [PATCH]Alignment error in German AI summary screenAlignment error in German AI summary screen

Unassigning for lack of activity.

comment:17 by Itms, 6 years ago

Component: UI & SimulationI18n & L10n
Description: modified (diff)
Note: See TracTickets for help on using tickets.