Serializer crashes when rejoining

[elexis]

For some days I get a crash with like 50% probability when I rejoin a hosted game with the most recent svn version.

StdDeserializer.cpp(114): Assertion failed: "m_ScriptBackrefs.size() > tag"
Assertion failed: "m_ScriptBackrefs.size() > tag"
Location: StdDeserializer.cpp:114 (GetScriptBackref)

[elexis]

It seems that it only crashes on the second rejoin.

[elexis]

With r16514 and earlier revisions I get the following AuraManager errors when rejoining twice:

WARNING: JavaScript warning: simulation/components/Auras.js line 437
reference to undefined property mod.value
...
WARNING: JavaScript warning: simulation/components/Auras.js line 427
reference to undefined property mod.value
ERROR: JavaScript error: simulation/components/AuraManager.js line 59
TypeError: value is undefined
  AuraManager.prototype.ApplyBonus@simulation/components/AuraManager.js:59:69
  Auras.prototype.ApplyBonus@simulation/components/Auras.js:427:3
  Auras.prototype.OnRangeUpdate@simulation/components/Auras.js:302:4
ERROR: Script message handler OnRangeUpdate failed
ERROR: JavaScript error: simulation/components/AuraManager.js line 116
TypeError: value is undefined
  AuraManager.prototype.RemoveBonus@simulation/components/AuraManager.js:116:69
  Auras.prototype.RemoveBonus@simulation/components/Auras.js:437:3
  Auras.prototype.OnRangeUpdate@simulation/components/Auras.js:311:4
ERROR: Script message handler OnRangeUpdate failed

With r16515 and later 0ad crashes with the serializer error mentioned in the description.

[fcxSanya]

A related ticket with some more details: #3164

[elexis]

After rebooting and using the most recent revision, i.e. 16562 I get the crash only occasionally, but either the AuraManager error or crash appears when rejoining twice.

With the nested_maps.diff patch in #3164 I only get an OOS on second rejoin, no errors, no crash. The OOS might be unrelated.

[historic_bruno]

Replying to elexis:

With the nested_maps.diff patch in #3164 I only get an OOS on second rejoin

Maps were removed, is this report still valid, do you have oos dumps for it?

[elexis]

Replying to historic_bruno:

Maps were removed, is this report still valid, do you have oos dumps for it?

I didn't experience any crashes or Aura errors since r16591. oos dumps were not generated, since it is not oos but the application crashes. I don't have coredumps.

The crash was probably caused by the aura serialization error in combination with the new version of gloox.

[Itms]

In 16929:

Revert r16591.

The problem caused by nested Maps is actually #3374.
Cloning the data object saved by the AuraManager fixes #3188.
Also, using Map fixes a serialization problem, refs #3375.

On top of those changes, some reordering of add/multiply to avoid any ordering mistake.

Fixes #3164, Refs #3374