Opened 9 years ago
Last modified 8 years ago
#3205 closed defect
[PATCH] Too dark colors for playernames in multiplayer lobby and gamesetup_chat — at Version 5
| Reported by: | fpre_O_O_O_O_O_O | Owned by: | |
|---|---|---|---|
| Priority: | Should Have | Milestone: | Alpha 20 |
| Component: | Multiplayer lobby | Keywords: | patch |
| Cc: | Patch: |
Description (last modified by )
Some players with short names get dark blue as the color for their nickname. Since the names are short and the color is very dark on dark background, you have a hard time reading that playername without zooming in / going closer to the screen.
This can be fixed easily by increasing the minimum brightness of the player color chosen.
This patch enlightens too dark colors by increasing the minimum lightness: attachment:t3205_enlighten_too_dark_chat_colors.patch:ticket:3205
Here a comparison (left without patch, right with patch):
Change History (18)
by , 9 years ago
| Attachment: | lobby_color_fix.patch added |
|---|
comment:1 by , 9 years ago
| Description: | modified (diff) |
|---|---|
| Keywords: | patch review added |
| Summary: | to dark colors in playernames in multiplayer lobby like dark blue as unreadable → [PATCH] Too dark colors for playernames in multiplayer lobby |
comment:2 by , 9 years ago
| Description: | modified (diff) |
|---|
by , 9 years ago
| Attachment: | gamesetup_player_colors_in_chat.png added |
|---|
new colors for chat (enlighted)
comment:3 by , 9 years ago
| Summary: | [PATCH] Too dark colors for playernames in multiplayer lobby → [PATCH] Too dark colors for playernames in multiplayer lobby and gamesetup_chat |
|---|
by , 9 years ago
| Attachment: | new_common_color_file.patch added |
|---|
new file for merging hsl to rgb function necessary for lobby and gamesetup colors into one file spreading them over to both
by , 9 years ago
| Attachment: | gamesetup_xml_colors_fix.patch added |
|---|
new xml file due to using color.js from gui/common/ now
by , 9 years ago
| Attachment: | lobby_xml_colors_fix.patch added |
|---|
new xml file due to using color.js from gui/common/ now
by , 9 years ago
| Attachment: | gamesetup_colors_fix.patch added |
|---|
fix player colors in gamesetup for better reading
by , 9 years ago
| Attachment: | t3205_enlighten_too_dark_chat_colors.patch added |
|---|
Thanks for uploading a patch with all changes in a single file. Unfortunately this patch can't be applied, since the directory names are different. This patch works for SVN. The only thing I still would change is the red color in the gamesetup chat, it looks too bright in my opinion. Not sure how to fix this without making blue unreadable again and not changing each color individually (maybe thats just the easiest way then?).
by , 9 years ago
| Attachment: | comparison.png added |
|---|
A comparison between the playerlist without (left) and with the patch (right). Notice how you can't read the name PA without zooming in. It seems all players with 3 letters are affected of the blue that is too dark. Also notice that most of the player colors are untouched while only those that are really too dark are fixed.
comment:5 by , 9 years ago
| Description: | modified (diff) |
|---|
quick fix for dark colors