Opened 9 years ago
Last modified 9 years ago
#3253 closed defect
Playernames not initialized correctly — at Version 1
Reported by: | elexis | Owned by: | |
---|---|---|---|
Priority: | Must Have | Milestone: | Alpha 19 |
Component: | UI & Simulation | Keywords: | |
Cc: | Patch: |
Description (last modified by )
"Player X" instead of the actual playername is displayed in many places, for example
- in the wonder victory message ("Player X will have won in Y", see #3226)
- in the tooltip of trade carts (getTradingTooltip in utility_functions.js)
- in the tooltips for tributing resources
- in the commands.txt file (correct playernames would be needed by visual replay #9)
- If someone disconnects and another player resigns, then the name of the disconnected player will change to "Player X" in all places where the correct playername was printed before (for example in the panels or diplomacy menu). This is because updateDiplomacy() in messages.js overwrites the player data with the default playernames.
Change History (2)
comment:1 by , 9 years ago
Description: | modified (diff) |
---|
by , 9 years ago
Attachment: | t3253_copy_playernames_on_init.patch added |
---|
Note:
See TracTickets
for help on using tickets.
Solves all the issues described above, except the trade tooltip, which will be handled in #3252.