[PATCH] Stand ground units don't attack

[Karamel]

On stand ground stance, units try to use Capture to hold position and will attack only when attacked.

This patch prevent GetBestAttack to pick Capture (the first declared).

[Karamel]

Static attack preference for best attack

[Vladislav Belov]

You can replace this.GetAttackTypes().pop(); to types.pop();. And what's with line breaks?

[leper]

Should be solved by querying with the biggest range, or best attack against a target instead of hard-coding more things.

[sanderd17]

There's a separate function to determine the best attack against a target. The overall best attack is hard to determine.

IMO, this function should be deleted, and the code that uses it should instead consider what might be the best attack.

[Karamel]

GetBestAttack was only used to check range in standing ground and as a workaround for some formation versus formation while defending or standing ground.

I replaced it by GetFullAttackRange to get the full action range. The formation part is more complex and need a lot of more work in formation orders to be fixed (and it wasn't more elegant). It will be subject to more tickets and patches.

[Karamel]

GetBestAttack replacement patch

[Karamel]

Attack patch with code style review

[Karamel]

Here is the latest patch with code style review from Itms

[Stan]

Pushing it as we are in FF

[mimo]

In 17109:

fix standGround units not attacking, patch by karamel, fixes #3284

[mimo]

As all turrets are in standground, this bug was affecting the garrison on walls, so I've pushed it back to a19.

karamel, thanks for the patch. I nonetheless slightly modified it (main change is using "for of" instead of "for in" for arrays when you don't need the array indices).