[PATCH] 'The Developer Overlay was opened.' is translated in the wrong place

[elexis]

If you open the developers overlay with Alt+D, then your computer translates this message and sends it via the ingame chat.

However it should be translated after it was received, so that everyone can read this message in the language that is currently set.

On unix you can open two instances of 0ad, change the language setting in one and host a multiplayer game to reproduce the issue.

[elexis]

• The strings to be translated are extracted by the extractor. It checks all files for translate, markForTranslation and related calls. It can only work in case the argument of these calls is a string, not an expression like "x" + "y".

• Dont' reinvent but reuse methods (submitChatDirectly)
• "/translate" instead of "/raw" would fit better

• Instead of using such an implementation, better send a simulation command of type aichat

[elexis]

In 17789:

Translate the developer-overlay notification at the receiving end, fixes #3304.

[elexis]

r17789 doesn't work with observers opening the developer overlay, as they can't send simulation commands. This issue becomes more prevalent if we want to add more GUI messages, for example when changing the perspective to another player. So we have to use the regular chat network message instead of a simulation command, hence /translate in conjunction with markForTranslation if we want to translate clientside in all cases, not too far from your approach.

[elexis]

In 20055:

Display untranslated developer overlay chat message if an observer opens it (rather than no message at all) following rP17789.

Remove a TODO from rP18441 (message boxes should never be closed automatically because they require a user decision).

Differential Revision: ​https://code.wildfiregames.com/D830
Refs #3304