[PATCH] Summary screen fails if a team number is skipped

[elexis]

If you start a match with team 1 and team 3 but no team 2, then the summary screen throws some errors and doesn't display any results at all:

WARNING: JavaScript warning: gui/summary/summary.js line 198
reference to undefined property g_Teams[i]
WARNING: JavaScript warning: gui/summary/layout.js line 248
reference to undefined property g_Teams[i]
WARNING: ClientArea definitions may only contain numerics. Your input: '50 NaN 100% NaN'
ERROR: JavaScript error: gui/summary/layout.js line 254
Error: Invalid value for setting 'size'
  updateGeneralPanelTeams@gui/summary/layout.js:254:3
  updatePanelData@gui/summary/summary.js:76:2
  selectPanel@gui/summary/summary.js:66:2
  init@gui/summary/summary.js:201:2
  leaveGame@gui/session/session.js:344:8
  g_messageBoxCallbackFunction@gui/common/functions_global_object.js:34:4
  init/action@gui/msgbox/msgbox.js:76:5

A null element was added to g_Teams implicitly, so two simple checks have been added in the patch attached.

[elexis]

Works with r16832.

[Itms]

In 16837:

Handle gaps in the teams list in the summary screen, plus code cleanup.

Patch by elexis, fixes #3323

[elexis]

The error message was fixed, but it doesn't group by teams if a team number was skipped.

[Imarok]

cannot reproduce: Is this already fixed?

[elexis]

I can't reproduce either anymore. Perhaps I had teams unlocked. Thanks for testing!