[PATCH] Time is not localized but in UTC

[elexis]

Currently the FormatMillisecondsIntoDateString function always returns the time in UTC (or GMT) and doesn't adapt to the local timezone (no matter how you define your language or country in the settings).

You can observe this issue in the lobby (chat timestamps) and in the savegame-loading-menu. The visual-replay-menu #3258 will also be affected.

Refs #1530 (outdated)

[leper]

Also note r16037 and #2938, so the proper fix would be to use actual dates.

[elexis]

In 17929:

Display chat-timestamps in the lobby in the correct timezone, refs #3350.

[elexis]

(The removal of L894-905 should have been committed in r17928 instead of r17929.)

[Itms]

In 17941:

Revert r17928.
It breaks the Windows build by using time_t and it changes too many things to the way lobby messages are processed to be entirely safe to commit now.
Refs #3832.

As a side effect it reverts r17929, refs #3350.

[Itms]

The fix above shows that we might face problems when using directly std::time and related functions on different platforms.

We should implement a CTime class for the engine that would allow us to fix a number of those date-time problems in a consistent and easily maintainable way.

[Imarok]

localize lobby chat timestamp (Based on r17929

[Imarok]

More general approach, fixing (hopefully) all places where non-localized time was used.

[Imarok]

If committed, the wiki should be changed (wiki:Internationalization)

[elexis]

Perhaps the C++ function itself should be changed. Since it's a file about localization, it would make sense to add the ability to localize a timestamp to that place. Should get the approach confirmed by Itms.

[Imarok]

Replying to elexis:

Perhaps the C++ function itself should be changed. Since it's a file about localization, it would make sense to add the ability to localize a timestamp to that place. Should get the approach confirmed by Itms.

Done: ​https://github.com/Imarok/0ad/tree/3350_local_time

[elexis]

In 18725:

Use the local timezone when localizing UTC timestamps. Patch by Imarok, fixes #3350, refs #2938.
Thus show the correct time in the lobby, savegame and replay menu.

[elexis]

Thanks for the patch!

See also ​http://icu-project.org/apiref/icu4c/classicu_1_1TimeZone.html LocalizeDateTime which is used for the build timestamp returns the formatted time in the current local timezone. The ingame timesamp has always been printed in the current timezone by using a JS function.

[Imarok]

backup of the correlating git branch

[Imarok]

In 19180:

Durations over 1 hour aren't displayed correctly

Reviewed by: elexis

Differential Revision: ​https://code.wildfiregames.com/D44

refs #4418, #3350