[PATCH] Gametime overlay shows wrong time, too small size

[elexis]

Bug 1) When exceeding 1h gametime, it displays 2h gametime (en-US locale, CET), likely introduced with the timezone change in r18725. All other uses of timeToString and FormatMillisecondsIntoDateString seem to be correct (as in receiving a Unix timestamp instead of a time without date). We should probably have 2 functions (one adapting the timezone, one that doesn't).

Bug 2) When exceeding 1h gametime and having a non-integer gamespeed (0.1x, ..., 1.5x) the counter GUI object is too small and it wraps over. It should instead use the maxTextWidth logic from displayGamestateNotifications (move it to a helper function). To be fixed in functions_global_object.js (those GUI objects being defined in global.xml).

[Imarok]

1) also occurs in "Time elapsed: " in the summary and in the replay duration shown in the replay menu Edit: afaics all uses of timeToString are wrong, because they are all used for a duration and not for a time (date without month, day and year)

[Imarok]

Fixes 1) by distinguishing between the localization of a time and the localitzation of a duration

[Imarok]

change isDuration to localTimezone

[elexis]

FormatMillisecondsIntoDateStringGMT and FormatMillisecondsIntoDateStringLocal?

[Imarok]

Don't use Duration

[elexis]

• Is the date really "converted to GMT"? Isn't the timestamp implied to be GMT?
• Prefered the naming convention above. If we have two variants, then one shouldn't have to find the name of the other variant to find out what the default one is doing.

[elexis]

Patch by Imarok at ​https://code.wildfiregames.com/D44

[Imarok]

In 19180:

Durations over 1 hour aren't displayed correctly

Reviewed by: elexis

Differential Revision: ​https://code.wildfiregames.com/D44

refs #4418, #3350

[Imarok]

Move tickets to In-game UI as UI & Simulation got some sub components.