[PATCH] OOS on rejoin - percentage of map controlled

[elexis]

<   "peakPercentMapControlled": 0,
<   "teamPeakPercentMapControlled": 0
---
>   "peakPercentMapControlled": 1,
>   "teamPeakPercentMapControlled": 1

Details will follow.

Refs #3321 #3378

[elexis]

Sample for r16988. Set of commands not minimized yet. Can't do serializationtest because of #3400.

[s0600204]

mimo on #0ad-dev:

could it be that the first computation is done on the square map, before recognizing it is a circular map?

Full points. ;)

Yes, the problem appears to be that the cost grid for territories is sometimes calculated whilst the map is still a square, and is then not recalculated after the map is reshaped into a circle.

Oddly enough, its the host that ends up with an incorrect cost grid - the rejoined client is calculating the grid correctly, albeit on the second go.

Coincidentally, I found that the map "Greek Acropolis Night (2)" also suffers from the same OOS problem.

The solution given in the soon-to-be-attached patch is to subscribe to and listen for a message that is transmitted when a map has changed shape, and to recompute the cost grid after receiving it.

[s0600204]

The afore-mentioned patch-to-be.

[leper]

In 16990:

Recompute the cost grid in the TerritoryManager when needed. Patch by s0600204. Fixes #3399, #3400.

[elexis]

Uses cheat to change phase on turn 0, serializationtest error on turn 1. r17131

[elexis]

Couldn't reproduce the error by phasing without cheats (yet?).

<   "peakPercentMapControlled": 5,
<   "teamPeakPercentMapControlled": 5
---
>   "peakPercentMapControlled": 9,
>   "teamPeakPercentMapControlled": 9

[elexis]

Fixes the OOS in case we would not commit #3525. If we commit that, then this patch is not necessary anymore (at least for this particular case where we age using a cheat). We might want to serialize it anyway, as there might be other unidentified cases.

[JoshuaJB]

In 17171:

Fix #3525 and #3399 by recalculating territories on request to GetTerritoryPercentage. Patch by elexis

[Josh]

I decided to adopt #3525's fix over this one. Thanks for the patch anyway.