Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#3420 closed defect (fixed)

[PATCH] Prevent opening the chat window after disconnect

Reported by: elexis Owned by: elexis
Priority: Nice to Have Milestone: Alpha 20
Component: UI & Simulation Keywords: patch
Cc: Patch:

Description

If a player for some reason gets disconnected from the host, the chat window can still be opened.

This should be prevented as neither chat nor cheats can be sent anymore.

Reproduce: 1) Host a multiplayer match with one instance 2) Join with the second instance 3) Start the game 4) Kill the host 5) Press enter with the (now disconnected) client

Attachments (1)

t3420_no_chat_after_disconnect_v1.patch​ (994 bytes ) - added by elexis 9 years ago.

Download all attachments as: .zip

Change History (6)

by elexis, 9 years ago

Attachment: t3420_no_chat_after_disconnect_v1.patch​ added

comment:1 by elexis, 9 years ago

Keywords: patch review added
Milestone: → Alpha 19
Summary: Prevent opening the chat window after disconnect → [PATCH] Prevent opening the chat window after disconnect

comment:2 by elexis, 9 years ago

Milestone: Alpha 19 → Alpha 20

wayne

comment:3 by elexis, 8 years ago

Owner: set to elexis
Resolution: → fixed
Status: new → closed

In 17315:

Closes the chat window after disconnect and prevents opening it again. Fixes #3420.

comment:4 by elexis, 8 years ago

Keywords: review removed

comment:5 by elexis, 8 years ago

In 17323:

Code cleanup. Refs #3420.
Since the window is now closed immediately after disconnect in messages.js, we don't need to close it in menu.js.

Note: See TracTickets for help on using tickets.