Chatting while waiting for other players to connect

[elexis]

Often if you play multiplayergames with many players, chances are that one of them has a computer with significantly less power, which results in everyone waiting for him/her to load the map.

In that case people chat already, while the "Waiting for other players to connect" is displayed. The problem is that the gray background overlay of that notification is drawn over the chat.

You can reproduce this Z-index-problem by not hiding that overlay when the game starts:

Index: binaries/data/mods/public/gui/session/messages.js
===================================================================
--- binaries/data/mods/public/gui/session/messages.js	(revision 17021)
+++ binaries/data/mods/public/gui/session/messages.js	(working copy)
@@ -255,11 +255,11 @@
 			obj.caption = translate("Synchronising gameplay with other players...");
 			obj.hidden = false;
 			break;
 		case "active":
 			obj.caption = "";
-			obj.hidden = true;
+			//obj.hidden = true;
 			break;
 		case "connected":
 			obj.caption = translate("Connected to the server.");
 			obj.hidden = false;
 			break;

Chatting at this point is not only nice, but a should-have, since there are rejoins causing further delays sometimes and even bugs preventing the start of the game (mentioned in ticket:3199#comment:3).

Simply setting the Z-index to zero of the netStatus object defined in session.xml works, but has a rendering bug: The overlay doesn't render around the chat text. (Same problem occurs when showing the entity state with the developers overlay while pausing the game, maybe we can fix both here).

[elexis]

(Refs #4375 to show which clients are still in the loading screen)

[elexis]

Fixed by ​Phab:D556 / rP19663.