[PATCH] Replay menu cleanups

[elexis]

The code is very clean already, but there are some minor things that can still be improved. Will attach multiple simple patches here.

Notice #3350 also applies to the replay menu.

Refs #3258 r17054 r17055

[elexis]

The last menu entry touched is off by 4 pixels. Noticed by niektb.

[elexis]

Uses SAFE_DELETE instead of delete.

[elexis]

Moves StartVisualReplay from JSInterface_VisualReplay.cpp to VisualReplay.cpp, so that this file contains all the logic. Also uses early return and eliminates a variable in AutostartVisualReplay.

[elexis]

Adds a warning to the main menu entry, that it might take some time to load initially.

[elexis]

TODO: hide or disable summary button if data is not available TODO: enhancement: Subtract the game duration of the filemoddate in case we are supplementing the timestamp on an a18 replay. This way those replays without timestamps list the start of the game instead of the end of the game.

[elexis]

Fix a compiler warning, fileSize is u64.

[elexis]

In 17313:

Corrects an offset of a menu entry. Thanks niektb for reporting. Refs #3440

[elexis]

In 17314:

Visual replay code cleanup. Refs #3440.

Moves StartVisualReplay() from JSInterface_VisualReplay.cpp to VisualReplay.cpp, so that the former doesn't define any logic.
Uses replayFile.string8() instead of utf8_from_wstring(replayFile.string()).
SAFE_DELETE instead of delete.
Fixes a compiler warning in getReplayDuration().

[elexis]

TODO: As mentioned by leper: void StartVisualReplay(CStrW directory);  -> const &

[elexis]

In 17356:

Replay menu cleanups. Fixes #3440.

Hides the summary-button in the replaymenu in case the summary wasn't saved.
Corrects the timestamp for incompatible replays.
Remove unused UNUSED from header files.
Use string8() instead of OsString().
Mention a reported compiler warning.
Use const& instead of a copy in StartVisualReplay().

[elexis]

I couldn't find a way yet to fix the compiler warning reported by fabio on gcc 5.2, without introducing a compiler warning on my own system.

../../../source/ps/VisualReplay.cpp: In function ‘int getReplayDuration(std::istream*, const CStr8&, const u64&)’:
../../../source/ps/VisualReplay.cpp:145:102: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘u64 {aka long long unsigned int}’ [-Wformat=]
    debug_printf("At position %i of %lu after %i lines reads.\n", currentPosition, fileSize, linesRead);

[elexis]

In 17359:

Renames to g_MapSizes, g_UserRating and g_SpamMonitor. Refs #3383 #3440

[elexis]

In 17367:

Remove debug parser from replay menu. Refs #3440