[PATCH] Visual replay menu - Civ and Name undefined for autostart games

[elexis]

If you start a match from command-line using the autostart arguments, the playerData objects may not contain the Civ property, causing an error when trying to show the description of that replay.

Reported by Stan.

[elexis]

That autostart code is not funny.

Currently autostart games on random maps use athen by default, see Autostart() in GameSetup.cpp. Skirmish maps use player_defaults.json and scenario maps come with predefined civs.

Also notice that autostart games might not have their Name property set.

So we just supplement all possible missing properties with the player defaults and mimic the weird civ-behaviour for random maps until we improve the autostart function.

[Stan]

I'm getting a similar issue when trying to replay Atlas commands,as there are no player_data too. ​http://pastebin.com/S9jiuMb6

[leper]

We could also not display anything in case the information is missing (and autostart is a dev only feature, so no point in adding a lot of code to support that in the replay menu). (Same for Atlas commands.txt which are most likely broken too)

We either should make autostart load some of those defaults or do as little work as possible to not cause any errors in the replay menu.

[Imarok]

Move tickets to their correct component.

[Langbart]

[26584] Let the Gamesetup.cpp Autostart (starting from cl) use the gamesettings via the autostart gui page.