[PATCH] Add a meta-cheat to abbreviate others

[elexis]

When doing test-games with cheats enabled, you have to type many sentences in order to activate all required cheats. If you have to repeat this process a couple of times (for example when reproducing a given bug) it becomes annoying quickly.

The usual cheats are:

• "the hive master" (full population capacity)
• "i am too busy" (build structures fast)
• 2x "back to the future" (advance phase)

A new cheat could be introduced that acts as an abbreviation for those three cheats. It would make some sense to add the following cheats too, if we introduce such a meta-cheat:

• i want pizza 100000 (add resources: food)
• bring me my axe 100000 (add resources: wood)
• your money or your life 100000 (add resources: metal)
• i see a mountain here 100000 (add resources: stone)
• TARDIS (500 population capacity)

This way you would have the additional benefit of not having to start with deathmatch resources.

See wiki:Manual_Cheats

[bb]

Working patch, implenting a metacheat "gift from the gods". Using exsisting functions (could change to direct cheating) and a loop around the resources might be needed.

[elexis]

Looks good to me and it could probably be committed like that. The code could be simplified a bit more though:

• AddResource:
  • Why have a type variable if you can just use the strings directly as the function argument?
  • using input.parameter as the second argument is good, but you could just add DefaultParameter to the JSON file instead of defining it in the javascript. Makes it a bit cleaner and the user could also change that value. (Also add the IsNumeric property then)
• To further improve the style: Instead of manipulating the existing input object, use the cheat function like Cheat({ "action": "maxpopulation" }); Notice the whitespace (see @wiki:Coding_Conventions)
• The early returns are good

Thank you for working on this! :)

[bb]

• To further improve the style: Instead of manipulating the existing input object, use the cheat function like Cheat({ "action": "maxpopulation" });

Changed the other things in my local version but when I change the statement above, I get crashes in the checks above the switch in "Cheat.js" when executing the function.

WARNING: JavaScript warning: simulation/helpers/Cheat.js line 4 reference to undefined property input.player

Probably because the "input" structure is not fully in the argument. So the "input.player" is not defined.

Notice the whitespace (see @wiki:Coding_Conventions)

Checked the code in "Cheat.js" on this and improved it :)

[elexis]

Right, you will need to pass the "player" attribute too (maybe others too, didn't look at it), i.e.

Cheat({
   "player": input.player,
   "action": "maxpopulation"
});

(I think you could replace the calls to AddResources with a calls to Cheat too. Would be a bit more coherent, but that's not really needed)

[bb]

Improved style of "Cheat.js"

[elexis]

Thanks for the cleanup, the existing code and your new code look even better than before.

• case "addresource": I think we can remove the for-loop and text.input change, not used, only one resource will be added.
• case "metacheat": wrong indentation
• Cheat: misssing semicolons

[bb]

Some more style improvements

[elexis]

In 17329:

Adds a new cheat as an abbreviation for most other cheats. Also cleans the code.
Fixes #3477. Patch by bb.

[elexis]

Thanks for the patch! :-) I removed some of the comments as the code should be clear enough already, one space after a return and one tab before 'case "metaCheat":'. Also I used a loop so we don't repeat code.

[elexis]

In 17330:

Forgot to add the JSON file. Refs #3477.